autumnust opened a new pull request #2551: [GOBBLIN-680] Enhance error handling 
on task creation
URL: https://github.com/apache/incubator-gobblin/pull/2551
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   In the process of creating `Task` object, especially in customized task 
execution framework, we usually see huge memory consumption in `Task` itself 
and it can run into `OutOfMemoryError` from time to time in one of our internal 
pipelines. `OutOfMemoryError` will not be caught by original implementation 
unfortunately since it is not an `Exception`. We added this implementation and 
corresponding testing code to make sure that, whenever there are virtual 
machine error like `OutOfMemoryError` happening, the `countDownLatch` is still 
being correctly handled. 
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-680] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-680
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to