[
https://issues.apache.org/jira/browse/GOBBLIN-685?focusedWorklogId=199521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199521
]
ASF GitHub Bot logged work on GOBBLIN-685:
------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/19 00:02
Start Date: 16/Feb/19 00:02
Worklog Time Spent: 10m
Work Description: yukuai518 commented on pull request #2557:
[GOBBLIN-685] Add dump jstack for EmbeddedGobblin
URL: https://github.com/apache/incubator-gobblin/pull/2557
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-685
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
In ticket https://jira01.corp.linkedin.com:8443/browse/ETL-8477, we don't
know why the thread would timeout. So two actions were taken:
1) When timeout happens, we will dump the jstack
2) Make cancellation executor a daemon thread, so that if won't be the
only hanging thread when no other non-daemon threads are active.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
EmbeddedGobblinTest
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 199521)
Time Spent: 10m
Remaining Estimate: 0h
> Add jstack when timeout happens in EmbeddedGobblin
> --------------------------------------------------
>
> Key: GOBBLIN-685
> URL: https://issues.apache.org/jira/browse/GOBBLIN-685
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Kuai Yu
> Assignee: Kuai Yu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
