sv2000 commented on a change in pull request #2555: [GOBBLIN-683] Add azkaban 
client retry logic.
URL: https://github.com/apache/incubator-gobblin/pull/2555#discussion_r258336828
 
 

 ##########
 File path: 
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/service/modules/orchestration/AzkabanClient.java
 ##########
 @@ -123,6 +135,12 @@ private void initializeSessionManager() throws 
AzkabanClientException {
     }
   }
 
+  private void intializeExecutorService() {
+    if (this.executorService == null) {
+      this.executorService = Executors.newFixedThreadPool(300);
 
 Review comment:
   300 threads may be too much. Is 30 too low? Also, do you think some of the 
retryer settings be made configurable? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to