[
https://issues.apache.org/jira/browse/GOBBLIN-697?focusedWorklogId=209236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209236
]
ASF GitHub Bot logged work on GOBBLIN-697:
------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/19 00:07
Start Date: 07/Mar/19 00:07
Worklog Time Spent: 10m
Work Description: yukuai518 commented on pull request #2568:
[GOBBLIN-697] Implementation of data file versioning and preservation in distcp.
URL: https://github.com/apache/incubator-gobblin/pull/2568#discussion_r263190264
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/filesystem/ModTimeDataFileVersion.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.util.filesystem;
+
+import java.io.IOException;
+import java.util.Set;
+
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
+import com.google.common.collect.ImmutableSet;
+import com.typesafe.config.Config;
+
+import lombok.Data;
+
+
+/**
+ * An implementation of {@link DataFileVersion} that uses modtime as the file
version.
+ */
+@Data
+public class ModTimeDataFileVersion implements DataFileVersion<Long> {
Review comment:
When do we use this ModTimeDataFileVersion? I remember in the design
document
(https://docs.google.com/document/d/1VhCHE2xfmwf4WTfle_wFhz-1U3TttIWDMU_YL0jkUbE/edit),
we will have 'version string' written by Purger, but at the same time we will
also have a 'version timestamp' that is equivalent to modTime in order to
detect the situation where a file is modified without updating the version. For
both cases, we need both versions to be set in the XAttr, but here the
setVersion returns false, did I miss something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 209236)
Time Spent: 0.5h (was: 20m)
> Allow distcp to carry over file version independently of modtime
> ----------------------------------------------------------------
>
> Key: GOBBLIN-697
> URL: https://issues.apache.org/jira/browse/GOBBLIN-697
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Issac Buenrostro
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Examples where this might be useful is data syncing between two locations.
> Relying on modification times to detect data changes may lead to a feedback
> loop of copying: data gets created at location A at time 0, at time 1 data is
> copied to location B, sync mechanism might incorrectly believe that since mod
> time of location B is higher, it should be synced back to location A, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
