ibuenros commented on a change in pull request #2576: [GOBBLIN-706]enable
dynamic mappers
URL: https://github.com/apache/incubator-gobblin/pull/2576#discussion_r268284121
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaWorkUnitPacker.java
##########
@@ -362,6 +362,15 @@ public static KafkaWorkUnitPacker getInstance(PackerType
packerType, AbstractSou
throw new IllegalArgumentException("WorkUnit packer type " +
packerType + " not found");
}
}
+ public double getWorkUnitEstSizes(Map<String, List<WorkUnit>>
workUnitsByTopic){
Review comment:
You can make the other method public. In general, it is a bad idea to have
the same logic duplicated in different locations.
Also, please add javadoc to any public methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
