ibuenros commented on a change in pull request #2579: [GOBBLIN-712] Add version
strategy pickup for ConfigBasedDataset distcp workflow
URL: https://github.com/apache/incubator-gobblin/pull/2579#discussion_r271003747
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/replication/ConfigBasedDataset.java
##########
@@ -128,6 +175,17 @@ public String datasetURN() {
return copyableFiles;
}
+ if (!this.srcDataFileVersionStrategy.isPresent() ||
!this.dstDataFileVersionStrategy.isPresent()) {
+ log.warn("Version strategy doesn't exist, cannot handle copy");
+ return copyableFiles;
+ }
+
+ if (!this.srcDataFileVersionStrategy.get().getClass().getName()
+ .equals(this.dstDataFileVersionStrategy.get().getClass().getName())) {
+ log.warn("Version strategy doesn't match, cannot handle copy");
Review comment:
Let's print out the src and target strategies for easier debuggability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
