[
https://issues.apache.org/jira/browse/GOBBLIN-708?focusedWorklogId=223080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223080
]
ASF GitHub Bot logged work on GOBBLIN-708:
------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 16:23
Start Date: 04/Apr/19 16:23
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2577: GOBBLIN-708:
Create SqlDatasetDescriptor for JDBC-sourced datasets.
URL: https://github.com/apache/incubator-gobblin/pull/2577#discussion_r272260089
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/EncryptionConfig.java
##########
@@ -20,18 +20,21 @@
import java.io.IOException;
import com.google.common.base.Enums;
-import com.google.common.base.Joiner;
import com.google.common.collect.ImmutableMap;
import com.typesafe.config.Config;
import com.typesafe.config.ConfigFactory;
+import lombok.EqualsAndHashCode;
import lombok.Getter;
+import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
import
org.apache.gobblin.service.modules.flowgraph.DatasetDescriptorConfigKeys;
import org.apache.gobblin.util.ConfigUtils;
@Slf4j
+@ToString(exclude = {"rawConfig"})
Review comment:
nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 223080)
Time Spent: 0.5h (was: 20m)
> Create SqlDatasetDescriptor for JDBC-sourced datasets
> ------------------------------------------------------
>
> Key: GOBBLIN-708
> URL: https://issues.apache.org/jira/browse/GOBBLIN-708
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Create a new DatasetDescriptor for JDBC sourced datasets.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
