[
https://issues.apache.org/jira/browse/GOBBLIN-736?focusedWorklogId=227396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227396
]
ASF GitHub Bot logged work on GOBBLIN-736:
------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/19 23:29
Start Date: 14/Apr/19 23:29
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2602: [GOBBLIN-736]
Skip flush and control message handlers on closed write…
URL: https://github.com/apache/incubator-gobblin/pull/2602
…rs in the CloseOnFlushWriterWrapper
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-736
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
The CloseOnFlushWriterWrapper calls operations on the underlying handler to
handle flush and metadata update control messages. These operations should not
be done on a closed writer since the underlying writer may raise errors for
closed objects. Added early returns when a closed writer is detected.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added test cases to CloseOnFlushWriterWrapperTest.
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 227396)
Time Spent: 10m
Remaining Estimate: 0h
> Skip flush and control message handlers on closed writers in the
> CloseOnFlushWriterWrapper
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-736
> URL: https://issues.apache.org/jira/browse/GOBBLIN-736
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Hung Tran
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The CloseOnFlushWriterWrapper should not operate on the underlying writer
> after it is closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
