[
https://issues.apache.org/jira/browse/GOBBLIN-742?focusedWorklogId=229944&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229944
]
ASF GitHub Bot logged work on GOBBLIN-742:
------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/19 22:37
Start Date: 18/Apr/19 22:37
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2608: GOBBLIN-742:
Implement a FileSystem based JobConfigurationManager.
URL: https://github.com/apache/incubator-gobblin/pull/2608#discussion_r276856729
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FsSpecConsumer.java
##########
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.api;
+
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Properties;
+import java.util.concurrent.Future;
+
+import org.apache.avro.file.DataFileReader;
+import org.apache.avro.mapred.FsInput;
+import org.apache.avro.specific.SpecificDatumReader;
+import org.apache.commons.lang3.tuple.ImmutablePair;
+import org.apache.commons.lang3.tuple.Pair;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+
+import com.typesafe.config.Config;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.runtime.job_spec.AvroJobSpec;
+import org.apache.gobblin.util.CompletedFuture;
+
+@Slf4j
+public class FsSpecConsumer implements SpecConsumer<Spec> {
+ public static final String SPEC_PATH_KEY =
"gobblin.cluster.specConsumer.path";
+ public static final String VERB_KEY = "Verb";
+
+ private final Path specDirPath;
+ private final FileSystem fs;
+ private Map<URI, Path> specToPathMap = new HashMap<>();
+
+
+ public FsSpecConsumer(Config config) {
+ this.specDirPath = new Path(config.getString(SPEC_PATH_KEY));
+ try {
+ this.fs = this.specDirPath.getFileSystem(new Configuration());
+ } catch (IOException e) {
+ throw new RuntimeException("Unable to detect spec directory file system:
" + e, e);
+ }
+ }
+
+ /** List of newly changed {@link Spec}s for execution on {@link
SpecExecutor}. */
+ @Override
+ public Future<? extends List<Pair<SpecExecutor.Verb, Spec>>> changedSpecs() {
+ List<Pair<SpecExecutor.Verb, Spec>> specList = new ArrayList<>();
+ FileStatus[] fileStatuses;
+ try {
+ fileStatuses = this.fs.listStatus(this.specDirPath);
+ } catch (IOException e) {
+ log.error("Error when listing files at path: {}",
this.specDirPath.toString(), e);
+ return null;
+ }
+
+ for (FileStatus fileStatus : fileStatuses) {
+ DataFileReader<AvroJobSpec> dataFileReader;
+ try {
+ dataFileReader = new DataFileReader<>(new
FsInput(fileStatus.getPath(), this.fs.getConf()), new SpecificDatumReader<>());
+ } catch (IOException e) {
+ log.error("Error creating DataFileReader for: {}",
fileStatus.getPath().toString(), e);
+ continue;
+ }
+
+ AvroJobSpec avroJobSpec = null;
+ while (dataFileReader.hasNext()) {
+ avroJobSpec = dataFileReader.next();
+ break;
+ }
+
+ if (avroJobSpec != null) {
+ JobSpec.Builder jobSpecBuilder = new
JobSpec.Builder(avroJobSpec.getUri());
+ Properties props = new Properties();
+ props.putAll(avroJobSpec.getProperties());
+
jobSpecBuilder.withJobCatalogURI(avroJobSpec.getUri()).withVersion(avroJobSpec.getVersion())
+
.withDescription(avroJobSpec.getDescription()).withConfigAsProperties(props);
+
+ try {
+ if (!avroJobSpec.getTemplateUri().isEmpty()) {
+ jobSpecBuilder.withTemplate(new URI(avroJobSpec.getTemplateUri()));
+ }
+ } catch (URISyntaxException u) {
+ log.error("Error building a job spec: ", u);
+ continue;
+ }
+
+ String verbName = avroJobSpec.getMetadata().get(VERB_KEY);
+ SpecExecutor.Verb verb = SpecExecutor.Verb.valueOf(verbName);
+
+ JobSpec jobSpec = jobSpecBuilder.build();
+ specList.add(new ImmutablePair<SpecExecutor.Verb, Spec>(verb,
jobSpec));
+ this.specToPathMap.put(jobSpec.getUri(), fileStatus.getPath());
+ }
+ }
+ return new CompletedFuture<>(specList, null);
+ }
+
+
+ @Override
+ public void commit(Spec spec) throws IOException {
+ Path path = this.specToPathMap.get(spec.getUri());
+ if (path != null) {
+ this.fs.delete(path, true);
Review comment:
Should set the recursive flag to false to be safe since only file delete is
expected here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229944)
Time Spent: 0.5h (was: 20m)
> Implement a FileSystem based JobConfigurationManager
> ----------------------------------------------------
>
> Key: GOBBLIN-742
> URL: https://issues.apache.org/jira/browse/GOBBLIN-742
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This task aims to implement a FileSystem based JobConfigurationManager. The
> manager has an underlying SpecConsumer which reads specs from a config
> specified path on HDFS and persists them to a JobCatalog. On successful
> consumption of the spec by the manager , it is deleted from the original
> path. So on the next fetch, only new specs will be picked up by the
> JobConfigurationManager.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
