sv2000 opened a new pull request #2609: GOBBLIN-744: Support cancellation of a Helix workflow via a DELETE Spec. URL: https://github.com/apache/incubator-gobblin/pull/2609 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-744 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): This task supports the ability to interrupt and cancel a running job on a Gobblin Helix cluster via a DELETE Spec submitted to the JobConfigurationManager. The DELETE Spec should have "gobblin.cluster.shouldCancelRunningJobOnDelete" set to true for cancelling a running job. The default behavior is to simply delete the corresponding JobSpec from the JobCatalog. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: IntegrationJobCancelViaSpecSuite and ClusterIntegrationTest. ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
