shirshanka commented on a change in pull request #2610: [GOBBLIN-743]
Initialize Gobblin application master services with dyn…
URL: https://github.com/apache/incubator-gobblin/pull/2610#discussion_r277182592
##########
File path:
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/GobblinYarnAppLauncherTest.java
##########
@@ -156,32 +172,27 @@ public void setUp() throws Exception {
.getResource(GobblinYarnAppLauncherTest.class.getSimpleName() +
".conf");
Assert.assertNotNull(url, "Could not find resource " + url);
- this.config = ConfigFactory.parseURL(url)
- .withValue("gobblin.cluster.zk.connection.string",
-
ConfigValueFactory.fromAnyRef(testingZKServer.getConnectString()))
- .resolve();
+ this.config =
ConfigFactory.parseURL(url).withValue("gobblin.cluster.zk.connection.string",
ConfigValueFactory.fromAnyRef(testingZKServer.getConnectString())).resolve();
String zkConnectionString =
this.config.getString(GobblinClusterConfigurationKeys.ZK_CONNECTION_STRING_KEY);
- this.helixManager = HelixManagerFactory.getZKHelixManager(
-
this.config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY),
TestHelper.TEST_HELIX_INSTANCE_NAME,
- InstanceType.CONTROLLER, zkConnectionString);
+ this.helixManager = HelixManagerFactory
+
.getZKHelixManager(this.config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY),
TestHelper.TEST_HELIX_INSTANCE_NAME,
+ InstanceType.CONTROLLER, zkConnectionString);
this.gobblinYarnAppLauncher = new GobblinYarnAppLauncher(this.config,
clusterConf);
}
@Test
- public void testCreateHelixCluster() throws Exception {
+ public void testCreateHelixCluster()
+ throws Exception {
// This is tested here instead of in HelixUtilsTest to avoid setting up
yet another testing ZooKeeper server.
- HelixUtils.createGobblinHelixCluster(
-
this.config.getString(GobblinClusterConfigurationKeys.ZK_CONNECTION_STRING_KEY),
-
this.config.getString(GobblinClusterConfigurationKeys.HELIX_CLUSTER_NAME_KEY));
+ HelixUtils
Review comment:
formatting seems weird here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
