[
https://issues.apache.org/jira/browse/GOBBLIN-744?focusedWorklogId=230809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230809
]
ASF GitHub Bot logged work on GOBBLIN-744:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/19 17:58
Start Date: 22/Apr/19 17:58
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2609: GOBBLIN-744:
Support cancellation of a Helix workflow via a DELETE Spec.
URL: https://github.com/apache/incubator-gobblin/pull/2609#discussion_r277373797
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/FsScheduledJobConfigurationManager.java
##########
@@ -53,27 +51,26 @@ public FsScheduledJobConfigurationManager(EventBus
eventBus, Config config, Muta
@Override
protected void fetchJobSpecs() throws ExecutionException,
InterruptedException {
- List<Pair<SpecExecutor.Verb, Spec>> jobSpecs =
- (List<Pair<SpecExecutor.Verb, Spec>>)
this._specConsumer.changedSpecs().get();
+ List<Pair<SpecExecutor.Verb, JobSpec>> jobSpecs =
+ (List<Pair<SpecExecutor.Verb, JobSpec>>)
this._specConsumer.changedSpecs().get();
- for (Pair<SpecExecutor.Verb, Spec> entry : jobSpecs) {
- Spec spec = entry.getValue();
+ for (Pair<SpecExecutor.Verb, JobSpec> entry : jobSpecs) {
+ JobSpec jobSpec = entry.getValue();
SpecExecutor.Verb verb = entry.getKey();
if (verb.equals(SpecExecutor.Verb.ADD) ||
verb.equals(SpecExecutor.Verb.UPDATE)) {
Review comment:
Should call `postUpdateJobConfigArrival` for the update case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 230809)
Time Spent: 3h (was: 2h 50m)
> Support cancellation of a Helix workflow via a DELETE Spec
> ----------------------------------------------------------
>
> Key: GOBBLIN-744
> URL: https://issues.apache.org/jira/browse/GOBBLIN-744
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This task supports the ability to interrupt and cancel a running job on a
> Gobblin Helix cluster via a DELETE Spec submitted to the
> JobConfigurationManager. The DELETE Spec should have
> "gobblin.cluster.shouldCancelRunningJobOnDelete" set to true for cancelling a
> running job. The default behavior is to simply delete the corresponding
> JobSpec from the JobCatalog.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
