[
https://issues.apache.org/jira/browse/GOBBLIN-748?focusedWorklogId=231742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-231742
]
ASF GitHub Bot logged work on GOBBLIN-748:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/19 22:10
Start Date: 23/Apr/19 22:10
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2613:
[GOBBLIN-748]Craftsmanship code cleaning in Gobblin Service Code
URL: https://github.com/apache/incubator-gobblin/pull/2613#discussion_r277525235
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/template_catalog/FSFlowTemplateCatalog.java
##########
@@ -167,4 +159,21 @@ private Config loadHoconFileAtPath(Path filePath, boolean
allowUnresolved)
return ConfigFactory.parseReader(new InputStreamReader(is,
Charsets.UTF_8)).resolve(options);
}
}
+
+ /**
+ * Determine if an URI of a jobTemplate or a FlowTemplate is valid.
+ * @param flowURI The given job/flow template
+ * @return true to continue on loading.
Review comment:
Change to "true if the URI is valid."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 231742)
Time Spent: 50m (was: 40m)
> Craftsmanship code cleaning in GaaS
> ------------------------------------
>
> Key: GOBBLIN-748
> URL: https://issues.apache.org/jira/browse/GOBBLIN-748
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
