autumnust commented on a change in pull request #2624: [GOBBLIN-760] Improve retrying behavior of throttling client, add more informative … URL: https://github.com/apache/incubator-gobblin/pull/2624#discussion_r280011339
########## File path: gobblin-restli/gobblin-throttling-service/gobblin-throttling-service-client/src/main/java/org/apache/gobblin/util/limiter/BatchedPermitsRequester.java ########## @@ -87,6 +88,7 @@ private static final long RETRY_DELAY_ON_NON_RETRIABLE_EXCEPTION = 60000; // 10 minutes private static final double MAX_DEPLETION_RATE = 1e20; public static final int MAX_GROWTH_REQUEST = 2; + private static final long GET_PERMITS_MAX_SLEEP = 1000; Review comment: Add unit in name? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
