[ https://issues.apache.org/jira/browse/GOBBLIN-763?focusedWorklogId=236625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236625 ]
ASF GitHub Bot logged work on GOBBLIN-763: ------------------------------------------ Author: ASF GitHub Bot Created on: 02/May/19 23:08 Start Date: 02/May/19 23:08 Worklog Time Spent: 10m Work Description: zxcware commented on pull request #2627: [GOBBLIN-763] Support fields removal for compaction dedup key schema URL: https://github.com/apache/incubator-gobblin/pull/2627 …entation Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. - https://issues.apache.org/jira/browse/GOBBLIN-763 ### Description - [x] Here are some details about my PR: - Remove fields, specified by configuration `compaction.job.key.fieldBlacklist`, while computing compaction dedup key schema - Fix incorrect `AvroUtils.removeUncomparableFields` implementation, which only keeps the first field of any schema, dropping all other fields which have the same schema. ### Tests - [x] My PR adds the following unit tests: - `CompactionJobConfiguratorTest.testKeyFieldBlacklist` ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 236625) Time Spent: 10m Remaining Estimate: 0h > Support fields removal for compaction dedup key schema > ------------------------------------------------------ > > Key: GOBBLIN-763 > URL: https://issues.apache.org/jira/browse/GOBBLIN-763 > Project: Apache Gobblin > Issue Type: Task > Reporter: Zhixiong Chen > Assignee: Zhixiong Chen > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > - Remove fields, specified by configuration > `compaction.job.key.fieldBlacklist`, while computing compaction dedup key > schema > - Fix incorrect `AvroUtils.removeUncomparableFields` implementation, which > only keeps the first field of any schema, dropping all other fields which > have the same schema. -- This message was sent by Atlassian JIRA (v7.6.3#76005)