jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284486925
########## File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/event/JobEvent.java ########## @@ -31,6 +31,7 @@ public static final String LOCK_IN_USE = "LockInUse"; public static final String WORK_UNITS_MISSING = "WorkUnitsMissing"; public static final String WORK_UNITS_EMPTY = "WorkUnitsEmpty"; + public static final String WORK_UNITS_CREATED = "WorkUnitsCreated"; Review comment: seems like these event name constants are scattered between `JobEvents` class and `EventNames` enum. should we combine them? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services