krishh85 commented on a change in pull request #2636: [GOBBLIN-766] Emit
Workunits Created event
URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284967941
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java
##########
@@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext
jobContext)
jobState.setState(JobState.RunningState.COMMITTED);
isWorkUnitsEmpty = true;
return;
+ } else {
Review comment:
This depends on the consumer of the event. In our case we consume these
events in time-series and the workUnitsCreated event is set to 0 every minute
irrespective of this event emitted or otherwise and hence workUnitsEmpty helps
to distinguish in this scenario.
We could potentially emit both by removing the "else" clause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
