[
https://issues.apache.org/jira/browse/GOBBLIN-777?focusedWorklogId=246166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246166
]
ASF GitHub Bot logged work on GOBBLIN-777:
------------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/19 16:19
Start Date: 21/May/19 16:19
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2641: [GOBBLIN-777]
Remove container request after container allocation
URL: https://github.com/apache/incubator-gobblin/pull/2641#discussion_r286111891
##########
File path:
gobblin-yarn/src/test/java/org/apache/gobblin/yarn/YarnServiceTest.java
##########
@@ -197,8 +201,12 @@ public void tearDown() throws IOException,
TimeoutException, YarnException {
public void testScaleUp() {
this.yarnService.requestTargetNumberOfContainers(10,
Collections.EMPTY_SET);
+ Assert.assertFalse(this.yarnService.getMatchingRequestsList(64,
1).isEmpty());
Assert.assertEquals(this.yarnService.getNumRequestedContainers(), 10);
Assert.assertTrue(this.yarnService.waitForContainerCount(10, 60000));
+
+ // container request list that had entries earlier should now be empty
+ Assert.assertEquals(this.yarnService.getMatchingRequestsList(64,
1).size(), 0);
Review comment:
Assert.assertTrue(this.yarnService.getMatchingRequestsList(64,
1).isEmpty())? to be consistent with line 204?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 246166)
Time Spent: 40m (was: 0.5h)
> Remove container request after container allocation
> ---------------------------------------------------
>
> Key: GOBBLIN-777
> URL: https://issues.apache.org/jira/browse/GOBBLIN-777
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Hung Tran
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Due to YARN-1902, a request for containers may allocate more containers than
> desired since the requests are not automatically removed when a container is
> allocated.
> The Gobblin YarnService needs to work around this issue by removing a
> matching container request in the container allocation callback.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
