[
https://issues.apache.org/jira/browse/GOBBLIN-778?focusedWorklogId=246613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246613
]
ASF GitHub Bot logged work on GOBBLIN-778:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/19 08:23
Start Date: 22/May/19 08:23
Worklog Time Spent: 10m
Work Description: mvachhani commented on pull request #2642: GOBBLIN-778
- Moving config creation to a separate method
URL: https://github.com/apache/incubator-gobblin/pull/2642
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-778
### Description
- [ x] Here are some details about my PR, including screenshots (if
applicable):
SalesforceExtractor uses bulk connection to connect to Salesforce using bulk
API. Since bulkConnection is private variable it cannot be modified to pass
custom transportFactory via config.
This task is to separate the config creation from bulkApiLogin method so as
it can be overridden for passing custom params like setTransport.
### Tests
- [ x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
No new code added, this change only refactors the code into a separate
method.
### Commits
- [ x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 246613)
Time Spent: 10m
Remaining Estimate: 0h
> Enhance SalesforceExtractor bulkConnection config for setting transport
> factory
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-778
> URL: https://issues.apache.org/jira/browse/GOBBLIN-778
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-salesforce
> Reporter: Monish Vachhani
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SalesforceExtractor uses bulk connection to connect to Salesforce using bulk
> API. Since bulkConnection is private variable it cannot be modified to pass
> custom transportFactory via config.
> This task is to separate the config creation from bulkApiLogin method so as
> it can be overridden for passing custom params like setTransport.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
