[
https://issues.apache.org/jira/browse/GOBBLIN-775?focusedWorklogId=247740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-247740
]
ASF GitHub Bot logged work on GOBBLIN-775:
------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/19 22:10
Start Date: 23/May/19 22:10
Worklog Time Spent: 10m
Work Description: jack-moseley commented on pull request #2640:
[GOBBLIN-775] Add job level retries for gobblin service
URL: https://github.com/apache/incubator-gobblin/pull/2640#discussion_r287153336
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -457,6 +462,15 @@ private void submitJob(DagNode<JobExecutionPlan> dagNode)
{
JobSpec jobSpec = DagManagerUtils.getJobSpec(dagNode);
Map<String, String> jobMetadata =
TimingEventUtils.getJobMetadata(Maps.newHashMap(), jobExecutionPlan);
+ // Increment submission attempt
Review comment:
I don't think the incrementing logic should be in there because it could be
called at a time other than job submission. But I moved the logic for updating
the map to there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 247740)
Time Spent: 1h 10m (was: 1h)
> Add job level retry for gobblin service
> ---------------------------------------
>
> Key: GOBBLIN-775
> URL: https://issues.apache.org/jira/browse/GOBBLIN-775
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: Jack Moseley
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
