arjun4084346 commented on a change in pull request #2635: [GOBBLIN-771] add a few metrics for gobblin service URL: https://github.com/apache/incubator-gobblin/pull/2635#discussion_r287185042
########## File path: gobblin-metrics-libs/gobblin-metrics/src/main/java/org/apache/gobblin/metrics/ServiceMetricNames.java ########## @@ -37,5 +37,5 @@ public static final String RUN_IMMEDIATELY_FLOW_METER = "RunImmediatelyFlow"; public static final String RUNNING_FLOWS_COUNTER = "RunningFlows"; - public static final String FLOWS_ALREADY_RUNNING_GAUGE = "FlowsAlreadyRunning"; + public static final String COMPILED = "Compiled"; Review comment: I think 'Compiled' is ok, because we are appending flow details before it. e.g. ktwo.encryption_holdem_faro.Compiled = 1/0 seems better than ktwo.encryption_holdem_faro.CompiledFlows = 1/0 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
