[
https://issues.apache.org/jira/browse/GOBBLIN-772?focusedWorklogId=248222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-248222
]
ASF GitHub Bot logged work on GOBBLIN-772:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/19 18:47
Start Date: 24/May/19 18:47
Worklog Time Spent: 10m
Work Description: ibuenros commented on pull request #2637:
[GOBBLIN-772]Implement Schema Comparison Strategy during Disctp
URL: https://github.com/apache/incubator-gobblin/pull/2637#discussion_r287477265
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/extractor/FileAwareInputStreamExtractorWithCheckSchema.java
##########
@@ -39,32 +43,38 @@
* check if the schema matches the expected schema. If not it will abort the
job.
*/
-public class FileAwareInputStreamExtractorWithCheckSchema extends
FileAwareInputStreamExtractor{
+public class FileAwareInputStreamExtractorWithCheckSchema extends
FileAwareInputStreamExtractor {
Review comment:
@jhsenjaliya the reason we did this in a different class is because it is
leaking Avro details. CopySource and the associated extractor are able to copy
arbitrary files simply as byte streams. This particular extension requires the
copied files to be Avro.
In general, I think that in a byte copier any functionality that assumes a
schema associated with those bytes is pollution of the logic. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 248222)
> Implement Schema Comparison Strategy during Disctp
> --------------------------------------------------
>
> Key: GOBBLIN-772
> URL: https://issues.apache.org/jira/browse/GOBBLIN-772
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We need a schema comparison strategy to make sure the real schema and the
> expected schema have matching field names and types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
