[
https://issues.apache.org/jira/browse/GOBBLIN-785?focusedWorklogId=249627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249627
]
ASF GitHub Bot logged work on GOBBLIN-785:
------------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 20:40
Start Date: 28/May/19 20:40
Worklog Time Spent: 10m
Work Description: ibuenros commented on pull request #2650: [GOBBLIN-785]
remove wrapper isPartition function, use table.isPartitioned instead
URL: https://github.com/apache/incubator-gobblin/pull/2650#discussion_r288292535
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HiveUtils.java
##########
@@ -163,10 +163,4 @@ private static Configuration getHadoopConfiguration() {
return conf;
}
- /**
- * @return true if {@link Table} is partitioned.
- */
- public static boolean isPartitioned(Table table) {
Review comment:
Please leave the method and mark as deprecated. It is possible other
products are relying on this method as a library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249627)
Time Spent: 10m
Remaining Estimate: 0h
> remove wrapper isPartition function, use table.isPartitioned instead
> --------------------------------------------------------------------
>
> Key: GOBBLIN-785
> URL: https://issues.apache.org/jira/browse/GOBBLIN-785
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jay Sen
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> some places use {{HiveUtils.isPartitioned()}} which is un-necessary wrapper
> function, and some places uses direct {{HiveTable.isPartitioned()}} the later
> should be used consistently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
