[
https://issues.apache.org/jira/browse/GOBBLIN-787?focusedWorklogId=249728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249728
]
ASF GitHub Bot logged work on GOBBLIN-787:
------------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 23:57
Start Date: 28/May/19 23:57
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2653: [GOBBLIN-787]
Add an option to include the task start time in the out…
URL: https://github.com/apache/incubator-gobblin/pull/2653
…put file name
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-787
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
In some cases a task may be scheduled to run on multiple workers. One case
where this happens is when running with the Helix task execution framework.
Helix may reschedule a task on a different worker if it loses contact with a
worker. That worker may continue executing for some time before the task is
terminated. During this period if the output file names collide then there may
be an error during data publish.
Add an option "writer.addTaskTimestamp" that can be used to reduce the
chance of name collisions by appending a task startup timestamp to the file
name.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
LocalJobLauncherTest.testLaunchJobWithTaskTimestamps()
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249728)
Time Spent: 10m
Remaining Estimate: 0h
> Add an option to include the task start time in the output file name
> --------------------------------------------------------------------
>
> Key: GOBBLIN-787
> URL: https://issues.apache.org/jira/browse/GOBBLIN-787
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Hung Tran
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In some cases a task may be scheduled to run on multiple workers. One case
> where this happens is when running with the Helix task execution framework.
> Helix may reschedule a task on a different worker if it loses contact with a
> worker. That worker may continue executing for some time before the task is
> terminated. During this period if the output file names collide then there
> may be an error during data publish.
> Add an option "writer.addTaskTimestamp" that can be used to reduce the chance
> of name collisions by appending a task startup timestamp to the file name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
