htran1 commented on a change in pull request #2653: [GOBBLIN-787] Add an option
to include the task start time in the out…
URL: https://github.com/apache/incubator-gobblin/pull/2653#discussion_r288685725
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -529,9 +529,18 @@ protected void cleanup() {
*/
private DataWriter<Object> buildWriter()
throws IOException {
+ String writerId = this.taskId;
+
+ // Add the task starting time if configured.
+ // This is used to reduce file name collisions which can happen due to the
scheduling of a task on multiple workers.
+ // One case where this occurs is when a worker gets disconnected from a
Helix cluster.
Review comment:
Yes, name collisions can also happen in the sequential case if the task is
reassigned in the same job execution. There is also lack of isolation for the
task staging and task output in Helix execution mode since there is no task
attempt guid, so the task staging and task output directories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
