[
https://issues.apache.org/jira/browse/GOBBLIN-792?focusedWorklogId=252041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252041
]
ASF GitHub Bot logged work on GOBBLIN-792:
------------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/19 20:33
Start Date: 31/May/19 20:33
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2657: [GOBBLIN-792]
submit a GobblinTrackingEvent when jobs are compiled but not yet orchestrated
URL: https://github.com/apache/incubator-gobblin/pull/2657#discussion_r289540813
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -337,7 +356,8 @@ private void initialize(Dag<JobExecutionPlan> dag)
//Are there any jobs already in the running state? This check is for
Dags already running
//before a leadership change occurs.
for (DagNode<JobExecutionPlan> dagNode : dag.getNodes()) {
- if (DagManagerUtils.getExecutionStatus(dagNode) == RUNNING) {
+ if (DagManagerUtils.getExecutionStatus(dagNode) == RUNNING ||
+ DagManagerUtils.getExecutionStatus(dagNode) == PENDING) {
Review comment:
I think the PENDING check is unnecessary. The DagNode will have execution
status ExecutionStatus.UNKNOWN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 252041)
Time Spent: 40m (was: 0.5h)
> submit a GobblinTrackingEvent when jobs are compiled but not yet orchestrated
> -----------------------------------------------------------------------------
>
> Key: GOBBLIN-792
> URL: https://issues.apache.org/jira/browse/GOBBLIN-792
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
