sv2000 commented on a change in pull request #2665: [GOBBLIN-798] Clean up
workflows from Helix when the Gobblin applicat…
URL: https://github.com/apache/incubator-gobblin/pull/2665#discussion_r291690862
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterManager.java
##########
@@ -264,6 +268,12 @@ public synchronized void start() {
this.eventBus.register(this);
this.multiManager.connect();
+ // Standalone mode registers a handler to clean up on leadership change,
so don't do the cleanup
+ // now even if the option to clean up on startup is set.
+ if (this.cleanUpJobsOnStartup && !this.isStandaloneMode) {
Review comment:
Is this check needed for correctness or to avoid duplicate clean up calls?
If it is the latter, shouldn't the 2nd call be handled as a No-op?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
