[ https://issues.apache.org/jira/browse/GOBBLIN-798?focusedWorklogId=256244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256244 ]
ASF GitHub Bot logged work on GOBBLIN-798: ------------------------------------------ Author: ASF GitHub Bot Created on: 07/Jun/19 21:50 Start Date: 07/Jun/19 21:50 Worklog Time Spent: 10m Work Description: htran1 commented on pull request #2665: [GOBBLIN-798] Clean up workflows from Helix when the Gobblin applicat… URL: https://github.com/apache/incubator-gobblin/pull/2665#discussion_r291765182 ########## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java ########## @@ -161,4 +161,8 @@ public static final String CANCEL_RUNNING_JOB_ON_DELETE = GOBBLIN_CLUSTER_PREFIX + "job.cancelRunningJobOnDelete"; public static final String DEFAULT_CANCEL_RUNNING_JOB_ON_DELETE = "false"; + + // for cleaning up jobs on cluster manager startup + public static final String CLEAN_UP_JOBS_ON_MANAGER_START = GOBBLIN_CLUSTER_PREFIX + "cleanUpJobsOnManagerStart"; + public static final boolean DEFAULT_CLEAN_UP_JOBS_ON_MANAGER_START = false; Review comment: Yes, this is to keep behavior the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 256244) Time Spent: 1h 40m (was: 1.5h) > Clean up workflows from Helix when the Gobblin application master starts > ------------------------------------------------------------------------ > > Key: GOBBLIN-798 > URL: https://issues.apache.org/jira/browse/GOBBLIN-798 > Project: Apache Gobblin > Issue Type: Task > Reporter: Hung Tran > Assignee: Hung Tran > Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > If the application master aborts a new one may be spawned by YARN. The second > application master will resubmit the jobs. This results in duplicate jobs in > Helix and multiple instances of the job may run, resulting in duplicate data. > The Gobblin application master should clean up all workflows on startup to > avoid executing multiple instances of a job. >  -- This message was sent by Atlassian JIRA (v7.6.3#76005)