[
https://issues.apache.org/jira/browse/GOBBLIN-808?focusedWorklogId=265018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265018
]
ASF GitHub Bot logged work on GOBBLIN-808:
------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/19 21:52
Start Date: 21/Jun/19 21:52
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2674:
[GOBBLIN-808] implement azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r296405035
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -470,7 +531,18 @@ private void submitJob(DagNode<JobExecutionPlan> dagNode)
{
// The SpecProducer implementations submit the job to the underlying
executor and return when the submission is complete,
// either successfully or unsuccessfully. To catch any exceptions in
the job submission, the DagManagerThread
// blocks (by calling Future#get()) until the submission is completed.
- producer.addSpec(jobSpec).get();
+ Future addSpecFuture = producer.addSpec(jobSpec);
+
+ if (addSpecFuture instanceof CompletableFuture
Review comment:
If this block is only about setting azexecId, plz wrap it in a function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 265018)
Time Spent: 1h 20m (was: 1h 10m)
> implement azkaban job cancellation in Gobblin Service
> -----------------------------------------------------
>
> Key: GOBBLIN-808
> URL: https://issues.apache.org/jira/browse/GOBBLIN-808
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
