yukuai518 commented on a change in pull request #2677: Support encrypted
Salesforce client id and client secret
URL: https://github.com/apache/incubator-gobblin/pull/2677#discussion_r296966368
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceConnector.java
##########
@@ -64,8 +64,10 @@ public SalesforceConnector(State state) {
@Override
public HttpEntity getAuthentication() throws RestApiConnectionException {
log.debug("Authenticating salesforce");
- String clientId =
this.state.getProp(ConfigurationKeys.SOURCE_CONN_CLIENT_ID);
- String clientSecret =
this.state.getProp(ConfigurationKeys.SOURCE_CONN_CLIENT_SECRET);
+ String clientId = PasswordManager.getInstance(this.state)
Review comment:
Considering to reuse the same returned variable from
PasswordManager.getInstance(this.state)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
