jack-moseley commented on a change in pull request #2675: [GOBBLIN-810] Include 
flow edge ID in job name
URL: https://github.com/apache/incubator-gobblin/pull/2675#discussion_r301313296
 
 

 ##########
 File path: 
gobblin-service/src/test/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompilerTest.java
 ##########
 @@ -244,7 +244,7 @@ public void testCompileFlow() throws URISyntaxException, 
IOException {
     String flowGroup = "testFlowGroup";
     String flowName = "testFlowName";
     String expectedJobName1 = 
Joiner.on(JobExecutionPlan.Factory.JOB_NAME_COMPONENT_SEPARATION_CHAR).
-        join(flowGroup, flowName, "Distcp", "LocalFS-1", "HDFS-1");
+        join(flowGroup, flowName, "Distcp", "LocalFS-1:HDFS-1:localToHdfs");
 
 Review comment:
   Good point, updated flow edge to be joined on '_'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to