sv2000 commented on a change in pull request #2701: GOBBLIN-846: Enhance
LogCopier service to handle continuous YARN log …
URL: https://github.com/apache/incubator-gobblin/pull/2701#discussion_r312229990
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/logs/LogCopier.java
##########
@@ -178,53 +188,91 @@ protected Scheduler scheduler() {
return Scheduler.newFixedRateSchedule(0,
this.sourceLogFileMonitorInterval, this.timeUnit);
}
+ private boolean shouldIncludeLogFile(FileStatus logFile) {
Review comment:
This should be fine, since only the LogCopier thread will prune
copiedFileNames while LogCopyTask will add copiedFileNames. The main LogCopier
thread blocks until LogCopyTasks finish and then deletes files from the
copiedFileNames.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
