[
https://issues.apache.org/jira/browse/GOBBLIN-847?focusedWorklogId=291671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291671
]
ASF GitHub Bot logged work on GOBBLIN-847:
------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/19 00:38
Start Date: 09/Aug/19 00:38
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2702: [GOBBLIN-847]
Flow level sla
URL: https://github.com/apache/incubator-gobblin/pull/2702#discussion_r312293346
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtils.java
##########
@@ -198,4 +206,33 @@ static FailureOption
getFailureOption(Dag<JobExecutionPlan> dag) {
static void incrementJobAttempt(DagNode<JobExecutionPlan> dagNode) {
dagNode.getValue().setCurrentAttempts(dagNode.getValue().getCurrentAttempts() +
1);
}
+
+ /**
+ * flow start time is assumed to be same the flow execution id which is
timestamp flow request was received
+ * @param dagNode dag node in context
+ * @return flow execution id
+ */
+ static long getFlowStartTime(DagNode<JobExecutionPlan> dagNode) {
+ return getFlowExecId(dagNode);
+ }
+
+ /**
+ * get the sla from the dag node config.
+ * if time unit is not provided, it assumes time unit is minute.
+ * @param dagNode dag node for which sla is to be retrieved
+ * @return sla if it is provided, -1 otherwise
+ */
+ static long getFlowSla(DagNode<JobExecutionPlan> dagNode) {
Review comment:
getFlowSla -> getFlowSLA? Reads better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 291671)
Time Spent: 50m (was: 40m)
> add a flow level sla in gaas flows
> ----------------------------------
>
> Key: GOBBLIN-847
> URL: https://issues.apache.org/jira/browse/GOBBLIN-847
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> add a flow level sla in gaas flows, because sometimes azkaban jobs may not
> start and hence send any tracking event, or azkaban maybe down. in all those
> cases, we might have to kill the job so we can start a new job
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
