[
https://issues.apache.org/jira/browse/GOBBLIN-854?focusedWorklogId=293542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293542
]
ASF GitHub Bot logged work on GOBBLIN-854:
------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/19 02:19
Start Date: 13/Aug/19 02:19
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on pull request #2710:
[GOBBLIN-854] use typesafe config instead of java properties
URL: https://github.com/apache/incubator-gobblin/pull/2710
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-854
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
standalone mode SchedulerDaemon uses java properties, this ticket is to use
TypeSafe Config instead to make config standardized across the modes and also
enable config to take benefits of TypeSafe functionalities. Also it takes 2
different config file as argument, one as default and another as custom, we
probably only need one property file.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason: not required, no change in functionality
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 293542)
Time Spent: 10m
Remaining Estimate: 0h
> update config reader in standalone mode
> ---------------------------------------
>
> Key: GOBBLIN-854
> URL: https://issues.apache.org/jira/browse/GOBBLIN-854
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> standalone mode {{SchedulerDaemon}} uses java properties, this ticket is to
> use TypeSafe Config instead to make config standardized across the modes and
> also enable config to take benefits of TypeSafe functionalities.
> Also it takes 2 different config file as argument, one as default and another
> as custom, we probably only need one property file.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
