arjun4084346 commented on a change in pull request #2702: [GOBBLIN-847] Flow
level sla
URL: https://github.com/apache/incubator-gobblin/pull/2702#discussion_r313538303
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -473,22 +490,20 @@ private void initialize(Dag<JobExecutionPlan> dag)
/**
* Proceed the execution of each dag node based on job status.
*/
- private void pollAndAdvanceDag()
- throws IOException {
+ private void pollAndAdvanceDag() throws IOException, ExecutionException,
InterruptedException {
this.failedDagIdsFinishRunning.clear();
-
Map<String, Set<DagNode<JobExecutionPlan>>> nextSubmitted =
Maps.newHashMap();
List<DagNode<JobExecutionPlan>> nodesToCleanUp = Lists.newArrayList();
+
for (DagNode<JobExecutionPlan> node: this.jobToDag.keySet()) {
- long pollStartTime = System.nanoTime();
+ boolean slaKilled = slaKillIfNeeded(node);
+
JobStatus jobStatus = pollJobStatus(node);
- Instrumented.updateTimer(this.jobStatusPolledTimer, System.nanoTime()
- pollStartTime, TimeUnit.NANOSECONDS);
- if (jobStatus == null) {
- continue;
- }
+
+ ExecutionStatus status = getJobExecutionStatus(slaKilled, jobStatus);
Review comment:
Almost the same thing, less readable and giving less emphasis on the fact
that slaKilled affects the execution status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
