yukuai518 commented on a change in pull request #2707: [GOBBLIN-851] Provide
capability to disable Hive partition schema registration.
URL: https://github.com/apache/incubator-gobblin/pull/2707#discussion_r314042939
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtils.java
##########
@@ -211,7 +211,9 @@ private static StorageDescriptor
getStorageDescriptor(HiveRegistrationUnit unit)
State props = unit.getStorageProps();
StorageDescriptor sd = new StorageDescriptor();
sd.setParameters(getParameters(props));
- sd.setCols(getFieldSchemas(unit));
+ if (unit instanceof HiveTable) {
Review comment:
@autumnust , we already had differentiation in addSchemaPropertiesIfRequired
method, where we use `isRegisterSchema` flag to check if a schema needs to be
added. The logic here is to convert Gobblin hive obj to native hive obj, which
should follow the same check, otherwise we will see the exception due to a
missing schema. Please check my latest code change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
