autumnust commented on a change in pull request #2716: [GOBBLIN-861]Skip 
getPartition() call to Hive Metastore when a partition already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716#discussion_r314567012
 
 

 ##########
 File path: 
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/metastore/HiveMetaStoreBasedRegister.java
 ##########
 @@ -501,8 +482,30 @@ private void addOrAlterPartition(IMetaStoreClient client, 
Table table, HiveParti
       }
     }
   }
+  protected void OnPartitionExist(IMetaStoreClient client, Table table, 
HivePartition partition, Partition nativePartition, TException e) throws 
TException {
 
 Review comment:
   Why not make `addOrAlterPartition` protected and overwrite that ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to