[
https://issues.apache.org/jira/browse/GOBBLIN-860?focusedWorklogId=297387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297387
]
ASF GitHub Bot logged work on GOBBLIN-860:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/19 20:18
Start Date: 19/Aug/19 20:18
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2715:
[GOBBLIN-860] Process flow-level events for setting/retrieving flow status
URL: https://github.com/apache/incubator-gobblin/pull/2715#discussion_r315392590
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowStatusResource.java
##########
@@ -106,14 +107,22 @@ private FlowStatus
convertFlowStatus(org.apache.gobblin.service.monitoring.FlowS
JobStatusArray jobStatusArray = new JobStatusArray();
FlowId flowId = new
FlowId().setFlowName(monitoringFlowStatus.getFlowName())
.setFlowGroup(monitoringFlowStatus.getFlowGroup());
- long flowStartTime = Long.MAX_VALUE;
- long flowEndTime = -1L;
- // flow execution status is complete unless job status indicates it is
running or failed
- ExecutionStatus flowExecutionStatus = ExecutionStatus.COMPLETE;
+
+ long flowEndTime = 0L;
+ ExecutionStatus flowExecutionStatus = ExecutionStatus.$UNKNOWN;
+
StringBuffer flowMessagesStringBuffer = new StringBuffer();
while (jobStatusIter.hasNext()) {
org.apache.gobblin.service.monitoring.JobStatus queriedJobStatus =
jobStatusIter.next();
+
+ // Check if this is the flow status instead of a single job status
+ if (queriedJobStatus.getJobName().equals(JobStatusRetriever.NA_KEY) &&
queriedJobStatus.getJobGroup().equals(JobStatusRetriever.NA_KEY)) {
Review comment:
maybe move this to a separate method `boolean isFlowStatus(JobStatus)` for
readability purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 297387)
Time Spent: 0.5h (was: 20m)
> Process flow-level events for setting/retrieving flow status
> ------------------------------------------------------------
>
> Key: GOBBLIN-860
> URL: https://issues.apache.org/jira/browse/GOBBLIN-860
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
