[ https://issues.apache.org/jira/browse/GOBBLIN-865?focusedWorklogId=304789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304789 ]
ASF GitHub Bot logged work on GOBBLIN-865: ------------------------------------------ Author: ASF GitHub Bot Created on: 31/Aug/19 06:13 Start Date: 31/Aug/19 06:13 Worklog Time Spent: 10m Work Description: arekusuri commented on pull request #2722: GOBBLIN-865: Add feature that enables PK-chunking in partition URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r319713198 ########## File path: gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java ########## @@ -896,6 +928,43 @@ private void reinitializeBufferedReader() throws IOException, AsyncApiException } } + private List<JsonElement> fetchWithRetry( Review comment: Bulk API has retry. It means if the result set is too big, it would retry 15 times creating/caching the result set This retry is our logic. When we fetch the result set file, if there is any failure, we want to retry specified times. It won't hurt. if the result file can be fetch at first time, the function returns the result set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 304789) Time Spent: 1h 10m (was: 1h) > Add feature that enables PK-chunking in partition > -------------------------------------------------- > > Key: GOBBLIN-865 > URL: https://issues.apache.org/jira/browse/GOBBLIN-865 > Project: Apache Gobblin > Issue Type: Task > Reporter: Alex Li > Priority: Major > Labels: salesforce > Time Spent: 1h 10m > Remaining Estimate: 0h > > In SFDC(salesforce) connector, we have partitioning mechanisms to split a > giant query to multiple sub queries. There are 3 mechanisms: > * simple partition (equally split by time) > * dynamic pre-partition (generate histogram and split by row numbers) > * user specified partition (set up time range in job file) > However there are tables like Task and Contract are failing time to time to > fetch full data. > We may want to utilize PK-chunking to partition the query. > > The pk-chunking doc from SFDC - > [https://developer.salesforce.com/docs/atlas.en-us.api_asynch.meta/api_asynch/async_api_headers_enable_pk_chunking.htm] -- This message was sent by Atlassian Jira (v8.3.2#803003)