[ https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=308089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308089 ]
ASF GitHub Bot logged work on GOBBLIN-868: ------------------------------------------ Author: ASF GitHub Bot Created on: 06/Sep/19 18:47 Start Date: 06/Sep/19 18:47 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2723: [GOBBLIN-868] Check flow status instead of job status to determine if flow is running URL: https://github.com/apache/incubator-gobblin/pull/2723#issuecomment-528971056 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=h1) Report > Merging [#2723](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/3523dbcdf41d489ece761c37f5849539cfc8948d?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `57.14%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2723 +/- ## ============================================ + Coverage 45.01% 45.01% +<.01% - Complexity 8740 8744 +4 ============================================ Files 1884 1884 Lines 70266 70267 +1 Branches 7709 7710 +1 ============================================ + Hits 31628 31634 +6 + Misses 35709 35703 -6 - Partials 2929 2930 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0% <0%> (ø)` | `2 <2> (+2)` | :arrow_up: | | [...org/apache/gobblin/service/FlowStatusResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...obblin/service/monitoring/FlowStatusGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9GbG93U3RhdHVzR2VuZXJhdG9yLmphdmE=) | `82.14% <100%> (-7.15%)` | `11 <1> (-1)` | | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `66.19% <0%> (+0.46%)` | `29% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0%> (+7.14%)` | `3% <0%> (ø)` | :arrow_down: | | [...g/apache/gobblin/service/monitoring/JobStatus.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXMuamF2YQ==) | `23.52% <0%> (+11.76%)` | `4% <0%> (+2%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=footer). Last update [3523dbc...bb1564d](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 308089) Time Spent: 1h (was: 50m) > Job statuses are still used for determining if a flow is running > ---------------------------------------------------------------- > > Key: GOBBLIN-868 > URL: https://issues.apache.org/jira/browse/GOBBLIN-868 > Project: Apache Gobblin > Issue Type: Bug > Reporter: Jack Moseley > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)