arekusuri commented on a change in pull request #2722: GOBBLIN-865: Add feature 
that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r321880074
 
 

 ##########
 File path: 
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceExtractor.java
 ##########
 @@ -896,6 +927,43 @@ private void reinitializeBufferedReader() throws 
IOException, AsyncApiException
     }
   }
 
+  private List<JsonElement> fetchPkChunkingResultSetWithRetry(
 
 Review comment:
   You are right! There is no wait! I copied the retry logic from 
**fetchResultBatchWithRetry**  and didn't look into it.
   I have another thought - Since the gobblin would re-execute the workUnit 
again anyway when the workUnit fails, we can just remove the retry. 
   how do you think of?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to