arjun4084346 opened a new pull request #2726: [GOBBLIN-871] make 
this.scheduledFlowSpecs a concurrent map because we update it wh…
URL: https://github.com/apache/incubator-gobblin/pull/2726
 
 
   …ile iterating over it
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   @sv2000  please review
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   to solve this exception
   java.util.ConcurrentModificationException 
   java.util.HashMap$HashIterator.nextNode - Line 1442 (HashMap.java) 
   java.util.HashMap$ValueIterator.next - Line 1471 (HashMap.java) 
   
org.apache.gobblin.service.modules.scheduler.GobblinServiceJobScheduler.setActive
 - Line 153 (GobblinServiceJobScheduler.java)
   
org.apache.gobblin.service.modules.core.GobblinServiceManager.handleLeadershipChange
 - Line 407 (GobblinServiceManager.java)
   org.apache.gobblin.service.modules.core.GobblinServiceManager.access$000 - 
Line 107 (GobblinServiceManager.java)
   
org.apache.gobblin.service.modules.core.GobblinServiceManager$2.onControllerChange
 - Line 436 (GobblinServiceManager.java)
   org.apache.helix.manager.zk.CallbackHandler.invoke - Line 209 
(CallbackHandler.java) 
   org.apache.helix.manager.zk.CallbackHandler.reset - Line 405 
(CallbackHandler.java) 
   org.apache.helix.manager.zk.ZKHelixManager.resetHandlers - Line 772 
(ZKHelixManager.java) 
   org.apache.helix.manager.zk.ZKHelixManager.handleNewSession - Line 849 
(ZKHelixManager.java) 
   org.I0Itec.zkclient.ZkClient$6.run - Line 736 (ZkClient.java) 
   org.I0Itec.zkclient.ZkEventThread.run - Line 72 (ZkEventThread.java) 
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   trivial
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to