autumnust commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322377318
 
 

 ##########
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
 ##########
 @@ -196,6 +196,11 @@ public GobblinTaskRunner(String applicationName,
     this.services.addAll(suite.getServices());
 
     this.services.addAll(getServices());
+
+    if (ConfigUtils.getBoolean(this.config, 
GobblinClusterConfigurationKeys.CONTAINER_HEALTH_METRICS_SERVICE_ENABLED, 
false)) {
 
 Review comment:
   Should we package this service as part of `TaskRunnerSuiteBase` instead of 
having a `this.services.addAll(getServices)` plus another service which is used 
for metric-reporting outside? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to