sv2000 commented on a change in pull request #2571: [GOBBLIN-701] Added the 
concept of secure job templates and job resolution callbacks.
URL: https://github.com/apache/incubator-gobblin/pull/2571#discussion_r322447907
 
 

 ##########
 File path: 
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
 ##########
 @@ -199,10 +202,13 @@ public AzkabanJobLauncher(String jobId, Properties props)
 
     Properties jobProps = this.props;
     if (jobProps.containsKey(TEMPLATE_KEY)) {
+      Config config = ConfigUtils.propertiesToConfig(jobProps);
+      JobSpecResolver resolver = JobSpecResolver.builder(config).build();
 
 Review comment:
   Shouldn't we pass a catalog (i.e. the PackagedTemplatesJobCatalogDecorator) 
to the JobSpecResolver Builder? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to