shirshanka commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322474783
 
 

 ##########
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java
 ##########
 @@ -167,4 +167,5 @@
 
   public static final String HELIX_JOB_STOPPING_STATE_TIMEOUT_SECONDS = 
GOBBLIN_CLUSTER_PREFIX + "job.stoppingStateTimeoutSeconds";
   public static final long DEFAULT_HELIX_JOB_STOPPING_STATE_TIMEOUT_SECONDS = 
300;
+  public static final String CONTAINER_HEALTH_METRICS_SERVICE_ENABLED = 
GOBBLIN_CLUSTER_PREFIX + "container.health.metrics.service.enabled" ;
 }
 
 Review comment:
   no default?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to