[ 
https://issues.apache.org/jira/browse/GOBBLIN-876?focusedWorklogId=309359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309359
 ]

ASF GitHub Bot logged work on GOBBLIN-876:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Sep/19 23:24
            Start Date: 09/Sep/19 23:24
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2730: GOBBLIN-876: 
Expose metrics() API in GobblinKafkaConsumerClient to al…
URL: https://github.com/apache/incubator-gobblin/pull/2730#discussion_r322495055
 
 

 ##########
 File path: 
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/AbstractBaseKafkaConsumerClient.java
 ##########
 @@ -84,6 +83,33 @@ public boolean apply(@Nonnull KafkaTopic kafkaTopic) {
     }));
   }
 
+  /**
+   * A helper method that returns the canonical metric name for a kafka 
metric. A typical canonicalized metric name would
+   * be of the following format: "{metric-group}_{client-id}_{metric-name}".
+   * @param metricGroup the type of the Kafka metric 
e.g."consumer-fetch-manager-metrics", "consumer-coordinator-metrics" etc.
+   * @param metricTags any tags associated with the Kafka metric, typically 
include the kafka client id, topic name, partition number etc.
+   * @param metricName the name of the Kafka metric e.g. "records-lag-max", 
"fetch-throttle-time-max" etc.
+   * @return the canonicalized metric name.
+   */
+  String canonicalMetricName(String metricGroup, Collection<String> 
metricTags, String metricName) {
 
 Review comment:
   Added a clarifying comment.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 309359)
    Time Spent: 2h 20m  (was: 2h 10m)

> Expose metrics() API in GobblinKafkaConsumerClient to allow consume metrics 
> to be reported
> ------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-876
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-876
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-kafka
>    Affects Versions: 0.15.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Shirshanka Das
>            Priority: Major
>             Fix For: 0.15.0
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Newer Kafka consumer expose metrics() API that report a number of consumer 
> metrics such as lag, latency, etc. which are very useful for monitoring and 
> debugging. We expose a metrics() API in GobblinKafkaConsumerClient to allow 
> consumer metrics to be reported. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to