[ 
https://issues.apache.org/jira/browse/GOBBLIN-876?focusedWorklogId=309383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309383
 ]

ASF GitHub Bot logged work on GOBBLIN-876:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Sep/19 23:57
            Start Date: 09/Sep/19 23:57
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2730: GOBBLIN-876: 
Expose metrics() API in GobblinKafkaConsumerClient to al…
URL: 
https://github.com/apache/incubator-gobblin/pull/2730#issuecomment-529628661
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2730?src=pr&el=h1)
 Report
   > Merging 
[#2730](https://codecov.io/gh/apache/incubator-gobblin/pull/2730?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/a409908079df873ba0d5a465df3e682be0e0085d?src=pr&el=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `4%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2730?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2730      +/-   ##
   ============================================
   + Coverage     44.99%   45.04%   +0.04%     
   - Complexity     8742     8754      +12     
   ============================================
     Files          1884     1885       +1     
     Lines         70295    70327      +32     
     Branches       7715     7716       +1     
   ============================================
   + Hits          31629    31678      +49     
   + Misses        35735    35710      -25     
   - Partials       2931     2939       +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2730?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../kafka/client/AbstractBaseKafkaConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9BYnN0cmFjdEJhc2VLYWZrYUNvbnN1bWVyQ2xpZW50LmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...bblin/kafka/client/GobblinKafkaConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9Hb2JibGluS2Fma2FDb25zdW1lckNsaWVudC5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...he/gobblin/kafka/client/Kafka09ConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4va2Fma2EvY2xpZW50L0thZmthMDlDb25zdW1lckNsaWVudC5qYXZh)
 | `76.81% <8.33%> (-14.42%)` | `8 <1> (ø)` | |
   | 
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
 | `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
   | 
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
 | `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `66.19% <0%> (+0.93%)` | `29% <0%> (ø)` | :arrow_down: |
   | 
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
 | `79.68% <0%> (+1.56%)` | `16% <0%> (+1%)` | :arrow_up: |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: |
   | 
[...orkunit/packer/KafkaSingleLevelWorkUnitPacker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FTaW5nbGVMZXZlbFdvcmtVbml0UGFja2VyLmphdmE=)
 | `12.5% <0%> (+12.5%)` | `1% <0%> (+1%)` | :arrow_up: |
   | ... and [2 
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2730/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2730?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2730?src=pr&el=footer).
 Last update 
[a409908...af8555f](https://codecov.io/gh/apache/incubator-gobblin/pull/2730?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 309383)
    Time Spent: 2.5h  (was: 2h 20m)

> Expose metrics() API in GobblinKafkaConsumerClient to allow consume metrics 
> to be reported
> ------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-876
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-876
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-kafka
>    Affects Versions: 0.15.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Shirshanka Das
>            Priority: Major
>             Fix For: 0.15.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Newer Kafka consumer expose metrics() API that report a number of consumer 
> metrics such as lag, latency, etc. which are very useful for monitoring and 
> debugging. We expose a metrics() API in GobblinKafkaConsumerClient to allow 
> consumer metrics to be reported. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to