sv2000 commented on a change in pull request #2729: GOBBLIN-875: Emit container
health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322506776
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
##########
@@ -196,6 +196,11 @@ public GobblinTaskRunner(String applicationName,
this.services.addAll(suite.getServices());
this.services.addAll(getServices());
+
+ if (ConfigUtils.getBoolean(this.config,
GobblinClusterConfigurationKeys.CONTAINER_HEALTH_METRICS_SERVICE_ENABLED,
false)) {
Review comment:
The TaskRunnerSuiteBase is an abstract class with two implementations,
process model and thread model. Wanted to leave getServices() in
TaskRunnerSuiteBase as an abstract method so as not to change the contract of
the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
