autumnust commented on a change in pull request #2729: GOBBLIN-875: Emit 
container health metrics when running in cluster mode
URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r322548013
 
 

 ##########
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java
 ##########
 @@ -196,6 +196,11 @@ public GobblinTaskRunner(String applicationName,
     this.services.addAll(suite.getServices());
 
     this.services.addAll(getServices());
+
+    if (ConfigUtils.getBoolean(this.config, 
GobblinClusterConfigurationKeys.CONTAINER_HEALTH_METRICS_SERVICE_ENABLED, 
false)) {
 
 Review comment:
   Sorry I should not mentioned `TaskRunnerSuiteBase`. What I meant to say is, 
does it make more sense to add this service inside `getServices` method in 
`GobblinTaskRunner` ?  
   
   The comment of `getServices` is :
   ```Creates and returns a {@link List} of additional {@link Service}s that 
should be run in this {@link GobblinTaskRunner}. Sub-classes that need 
additional {@link Service}s to run, should override this method```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to