zxcware commented on a change in pull request #2722: GOBBLIN-865: Add feature
that enables PK-chunking in partition
URL: https://github.com/apache/incubator-gobblin/pull/2722#discussion_r324384004
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java
##########
@@ -146,12 +156,98 @@ protected void addLineageSourceInfo(SourceState
sourceState, SourceEntity entity
@Override
protected List<WorkUnit> generateWorkUnits(SourceEntity sourceEntity,
SourceState state, long previousWatermark) {
+ String partitionType = state.getProp(PARTITION_TYPE, "");
+ if (partitionType.equals("PK_CHUNKING")) {
+ return generateWorkUnitsPkChunking(sourceEntity, state,
previousWatermark);
Review comment:
This is where to comment the right use cases to enable `PK_CHUNKING`, as
it's the entry point
```
// pk-chunking only supports start-time by
source.querybased.start.value, and does not support end-time.
// always ingest data later than or equal
source.querybased.start.value.
// we should only pk chunking based work units only in case of
snapshot/full ingestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
